Skip to content

Enhance comment formatting #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 27, 2017
Merged

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Aug 27, 2017

This PR

  1. implements recover_missing_comments_in_span(), which is generalized function for recovering missing comments in the given span.
  2. use it to recover missing comments.
  3. preserve blank line between doc comment and attribute
  4. apply some refactoring (e.g. use String::with_capacity() instead of String::new())

Closes #1887.
Closes #1911.

@nrc nrc merged commit 7298ce9 into rust-lang:master Aug 27, 2017
@nrc
Copy link
Member

nrc commented Aug 27, 2017

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants