Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

Emit a warning if automatically applied changes cause build to fail #88

Closed
alexcrichton opened this issue May 5, 2018 · 0 comments · Fixed by #93
Closed

Emit a warning if automatically applied changes cause build to fail #88

alexcrichton opened this issue May 5, 2018 · 0 comments · Fixed by #93

Comments

@alexcrichton
Copy link
Member

We've got logic to automatically back out changes in this situation but we should also warn the user when this happens. Ideally we'd even say what the fixes were in the file with the errors and what the relevant code looked like, also ideally with links and instructions of how to report a bug to us.
alexcrichton added a commit to alexcrichton/rustfix that referenced this issue May 6, 2018
@alexcrichton
Warn users when fixes break code
59b3617 
The rustfix tool detects it, so let's inform the user what just happened!

Closes rust-lang#88
@alexcrichton alexcrichton mentioned this issue May 6, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn users when fixes break code alexcrichton/rustfix
1 participant
@alexcrichton