Skip to content

Test FreeBSD on CI #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2021
Merged

Test FreeBSD on CI #1138

merged 3 commits into from
Feb 14, 2021

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Feb 14, 2021

Testing for one member of the BSD family should hopefully catch most issues with other members of the BSD family.

@bjorn3 bjorn3 added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Feb 14, 2021
Copy link
Member Author

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add support for a new OS in the BSD family you should only need to change...

@@ -34,13 +34,13 @@ done
# Build cg_clif
unset CARGO_TARGET_DIR
unamestr=$(uname)
if [[ "$unamestr" == 'Linux' ]]; then
if [[ "$unamestr" == 'Linux' || "$unamestr" == "FreeBSD" ]]; then
Copy link
Member Author

@bjorn3 bjorn3 Feb 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... this...

@@ -3,7 +3,7 @@
set -e

unamestr=$(uname)
if [[ "$unamestr" == 'Linux' ]]; then
if [[ "$unamestr" == 'Linux' || "$unamestr" == 'FreeBSD' ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and this.

@bjorn3
Copy link
Member Author

bjorn3 commented Feb 14, 2021

While testing I noticed that Cirrus CI quite often restarts builds as GCE preempts the VM. It also takes several minutes before a build starts.

@bjorn3 bjorn3 merged commit 1337f96 into master Feb 14, 2021
@bjorn3 bjorn3 deleted the cirrus_ci branch February 14, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant