-
Notifications
You must be signed in to change notification settings - Fork 107
Test FreeBSD on CI #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test FreeBSD on CI #1138
Conversation
FreeBSD doesn't have /bin/bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add support for a new OS in the BSD family you should only need to change...
@@ -34,13 +34,13 @@ done | |||
# Build cg_clif | |||
unset CARGO_TARGET_DIR | |||
unamestr=$(uname) | |||
if [[ "$unamestr" == 'Linux' ]]; then | |||
if [[ "$unamestr" == 'Linux' || "$unamestr" == "FreeBSD" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... this...
@@ -3,7 +3,7 @@ | |||
set -e | |||
|
|||
unamestr=$(uname) | |||
if [[ "$unamestr" == 'Linux' ]]; then | |||
if [[ "$unamestr" == 'Linux' || "$unamestr" == 'FreeBSD' ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and this.
While testing I noticed that Cirrus CI quite often restarts builds as GCE preempts the VM. It also takes several minutes before a build starts. |
Testing for one member of the BSD family should hopefully catch most issues with other members of the BSD family.