Skip to content

Disable llvm-lines testing of regex-1.5.5 on CI. #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

nnethercote
Copy link
Contributor

It hasn't worked for months, which means the "Test profiling" CI job has been failing all that time. In lieu of a proper fix, let's disable this small part of "Test profiling" to get it green again.

@nnethercote nnethercote requested a review from lqd March 9, 2023 01:00
@nnethercote nnethercote force-pushed the disable-llvm-lines-on-regex branch from aed55f2 to c9d3cc2 Compare March 9, 2023 01:01
@nnethercote nnethercote force-pushed the disable-llvm-lines-on-regex branch from c9d3cc2 to 675825c Compare March 9, 2023 01:29
@nnethercote nnethercote enabled auto-merge March 9, 2023 02:55
@nnethercote nnethercote disabled auto-merge March 9, 2023 02:55
@Kobzol
Copy link
Contributor

Kobzol commented Mar 9, 2023

This should have probably rather been rebased on master, right? The merge commit in a PR makes a mess in git history.

It hasn't worked for months, which means the "Test profiling" CI job has
been failing all that time. In lieu of a proper fix, let's disable this
small part of "Test profiling" to get it green again.
@rylev rylev force-pushed the disable-llvm-lines-on-regex branch from d0ca466 to a6dca0e Compare March 9, 2023 09:52
@rylev
Copy link
Member

rylev commented Mar 9, 2023

@Kobzol sorry! Took the lazy way out. I've rebased the PR on behalf of @nnethercote

@Kobzol Kobzol enabled auto-merge March 9, 2023 09:59
@Kobzol Kobzol merged commit 2895e72 into rust-lang:master Mar 9, 2023
@nnethercote nnethercote deleted the disable-llvm-lines-on-regex branch March 9, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants