Skip to content

Improve summary table and GitHub messaging #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2022

Conversation

rylev
Copy link
Member

@rylev rylev commented Apr 4, 2022

This includes several small tweaks:

  • Don't include footnotes defining terms in the triage report. Overall, it looks off, and if we decide we really need to define terms we should do it once per triage report.
  • Only show errored benchmark runs in the GitHub message (it's not really relevant for the triage report).
  • Show both primary and secondary benchmarks that error (we were previously only showing primary).
  • Tweak the GitHub message when there are not enough changes to be significant. It is possible that there are individual changes that on their own are deemed relevant, but the comparison as a whole isn't relevant. The new messaging makes this a bit clearer by saying the "changes [are] not relevant" (i.e., point to the whole) rather than "no relevant changes".

@rylev rylev requested a review from Kobzol April 4, 2022 15:55
@rylev rylev requested a review from Kobzol April 4, 2022 16:44
@rylev rylev enabled auto-merge April 5, 2022 08:01
@rylev rylev merged commit c5270d2 into rust-lang:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants