Clarify relevance #1271
Merged
Clarify relevance #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Apr 4, 2022
nnethercote
reviewed
Apr 5, 2022
nnethercote
reviewed
Apr 5, 2022
nnethercote
reviewed
Apr 5, 2022
nnethercote
reviewed
Apr 5, 2022
nnethercote
reviewed
Apr 5, 2022
nnethercote
reviewed
Apr 5, 2022
nnethercote
approved these changes
Apr 5, 2022
There was a problem hiding this comment.
I'm still not satisfied with all this terminology. It feels like it can be made simpler, more consistent, and more precise. It would take me some time to go over it all to come up with more specific suggestions.
Having said that, this is enough of an improvement over the status quo that I think it's worth merging, though addressing any/all of my comments below would be nice. Especially the one about how "relevance" sometimes means "confidence + magnitude" but sometimes it's just magnitude (as far as I can tell).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the terms "relevant test result comparison" and "test result comparison magnitude".
This does not fundamentally alter how we calculate magnitude or relevance; it just attempts to use more clear terminology.