Skip to content

Fix footnotes #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Fix footnotes #2365

merged 1 commit into from
Apr 29, 2025

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Apr 29, 2025

For some reason mdbook serve locally gives different output than in the built version of the dev guide... oh well

@BoxyUwU BoxyUwU merged commit 3c3aa7e into rust-lang:master Apr 29, 2025
1 check passed
@tshepang
Copy link
Member

tshepang commented Apr 29, 2025

was it maybe different mdbook versions... the footnote functionality of mdbook was recently changed

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Apr 29, 2025

As part of this change, footnotes are now only rendered at the bottom of the page

Ah yeah that would be it... that's an unfortunate change ah well. I'll update my local mdbook I guess :-)

@tshepang
Copy link
Member

oh, what's unfortunate about it... did you prefer previous behavior

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Apr 30, 2025

Yeah I was trying to have footnotes split between each "big header" so that readers would stay at "the same general context", but I guess it doesn't really matter since there's a nice button that takes you back to where you were anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants