Skip to content

[compiletest] Extract code to detect files related to a test into a different function #96517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions src/tools/compiletest/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,40 @@ fn stamp(config: &Config, testpaths: &TestPaths, revision: Option<&str>) -> Path
output_base_dir(config, testpaths, revision).join("stamp")
}

fn files_related_to_test(
config: &Config,
testpaths: &TestPaths,
props: &EarlyProps,
revision: Option<&str>,
) -> Vec<PathBuf> {
let mut related = vec![];

if testpaths.file.is_dir() {
// run-make tests use their individual directory
for entry in WalkDir::new(&testpaths.file) {
let path = entry.unwrap().into_path();
if path.is_file() {
related.push(path);
}
}
} else {
related.push(testpaths.file.clone());
}

for aux in &props.aux {
let path = testpaths.file.parent().unwrap().join("auxiliary").join(aux);
related.push(path);
}

// UI test files.
for extension in UI_EXTENSIONS {
let path = expected_output_path(testpaths, revision, &config.compare_mode, extension);
related.push(path);
}

related
}

fn is_up_to_date(
config: &Config,
testpaths: &TestPaths,
Expand All @@ -686,20 +720,10 @@ fn is_up_to_date(

// Check timestamps.
let mut inputs = inputs.clone();
// Use `add_dir` to account for run-make tests, which use their individual directory
inputs.add_dir(&testpaths.file);

for aux in &props.aux {
let path = testpaths.file.parent().unwrap().join("auxiliary").join(aux);
for path in files_related_to_test(config, testpaths, props, revision) {
inputs.add_path(&path);
}

// UI test files.
for extension in UI_EXTENSIONS {
let path = &expected_output_path(testpaths, revision, &config.compare_mode, extension);
inputs.add_path(path);
}

inputs < Stamp::from_path(&stamp_name)
}

Expand Down