Skip to content

Initialize rust-analyzer submodule on bootstrap #96457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2022

Conversation

yungkneez
Copy link
Contributor

Fixes #96456

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2022
@bjorn3
Copy link
Member

bjorn3 commented Apr 27, 2022

This is only needed when vendoring.

@yungkneez
Copy link
Contributor Author

This is only needed when vendoring.

Correct. I can modify the bootstrap script to only check it out if vendoring is enabled. Is that preferable?

@bjorn3
Copy link
Member

bjorn3 commented Apr 27, 2022

I think so. That would cause less waiting on the download in case rust-analyzer doesn't need to be built.

@yungkneez
Copy link
Contributor Author

Okay, it will now only checkout rust-analyzer if needed 😄

@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2022
@yungkneez
Copy link
Contributor Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2022
@yungkneez
Copy link
Contributor Author

@rustbot review

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 7, 2022

📌 Commit 2878f98 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@bors
Copy link
Collaborator

bors commented May 8, 2022

⌛ Testing commit 2878f98 with merge 30046ce...

@bors
Copy link
Collaborator

bors commented May 8, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 30046ce to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2022
@bors bors merged commit 30046ce into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (30046ce): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./x.py fails to bootstrap if build.vendor is set in config.toml
7 participants