-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Initialize rust-analyzer submodule on bootstrap #96457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
This is only needed when vendoring. |
Correct. I can modify the bootstrap script to only check it out if vendoring is enabled. Is that preferable? |
I think so. That would cause less waiting on the download in case rust-analyzer doesn't need to be built. |
Okay, it will now only checkout |
r=me with commits squashed |
@rustbot label -S-waiting-on-author +S-waiting-on-review |
@rustbot review |
@bors r+ |
📌 Commit 2878f98 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (30046ce): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Fixes #96456