Skip to content

Remove a few uses of @-pointers for @ast::Expr and @mut Block in trans #9615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove a few uses of @-pointers for @ast::Expr and @mut Block in trans #9615

wants to merge 3 commits into from

Conversation

bluss
Copy link
Member

@bluss bluss commented Sep 30, 2013

This is mostly an incremental change, picking off some uses of
@- or @mut-pointers that can be replaced by references.

Almost all of the builder functions in trans::build are updated,
mostly using &Block arguments instead of @mut Block.

blake2-ppc added 3 commits September 30, 2013 05:29
Use borrowed references in a few locations that were encountered when
working on other changes.
Use &mut Block and &Block references where possible in the builder
functions in trans::build.

@mut Block remains in a few functions where I could not (not yet at
least) track down the runtime borrowck failures.
@bluss
Copy link
Member Author

bluss commented Sep 30, 2013

Some hard-won but simple changes; it's was a small project for me to get to know rustc a bit. the @mut Block changes can definitely percolate up to the callers of those functions to give in further @-reduction in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants