Implement pattern ranges for all numeric types. #951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks great. Merged. |
|
Okay, I had to back this out. It breaks in a weird way on windows, and I can't get Rust to build at all on my windows VM today, so I can't debug it. |
|
This now build fine on my own windows machine, but still breaks on the windows tinderboxes. Possibly an LLVM update would help. |
|
I spent some time on this today and couldn't get the test to succeed on windows under check-fast though, naturally, it worked when run on it's own. |
|
Did you try with llvm HEAD? |
|
Yeah. |
|
So how about integrating this and, for the time, xfailing the test for check-fast? It seems a shame to let it bit-rot when it works in all sane situations. |
|
Integrated. Thanks! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2020
Simd improvements
ZuseZ4
pushed a commit
to EnzymeAD/rust
that referenced
this pull request
Mar 7, 2023
* Fix LCSSA lookup scope bug * temp * tmp * Fixup * update test
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
tgross35
pushed a commit
to tgross35/rust
that referenced
this pull request
Jun 14, 2025
Replace `build.rs` Rust generation with macros, using the unstable
`${concat(...)}`.
Fixes: rust-lang/compiler-builtins#947
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 18, 2025
Replace `build.rs` Rust generation with macros, using the unstable
`${concat(...)}`.
Fixes: rust-lang/compiler-builtins#947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.