Refactor the logging system for fewer allocations #9261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail to bootstrap unless #9257 lands first. |
| @@ -140,22 +168,21 @@ pub fn begin_unwind_(msg: *c_char, file: *c_char, line: size_t) -> ! { | |||
| let msg = str::raw::from_c_str(msg); | |||
| let file = str::raw::from_c_str(file); | |||
There was a problem hiding this comment.
Loosely related to this change: these actually allocate a new buffer, would it be possible for begin_unwind_ to be passed Rust strings and uints rather than C ones?
There was a problem hiding this comment.
That would be a nice change actually, it seems fairly nicely separable from this change, however, so I think I'd attempt to do it in a later commit.
|
bump, This may need to be rebased. |
| }; | ||
|
|
||
| task.logger.log(SendStrOwned(msg)); | ||
| match task.name { |
There was a problem hiding this comment.
Could this become something like
let name = task.name.map(|s| s.as_slice()).unwrap_or("<unnamed>");
format_args!(|arg| { ... }, "...", name, msg, file, line);
This lifts various restrictions on the runtime, for example the character limit when logging a message. Right now the old debug!-style macros still involve allocating (because they use fmt! syntax), but the new debug2! macros don't involve allocating at all (unless the formatter for a type requires allocation.
|
This is blocked on #9484 |
bors
added a commit
that referenced
this pull request
Sep 27, 2013
This lifts various restrictions on the runtime, for example the character limit when logging a message. Right now the old debug!-style macros still involve allocating (because they use fmt! syntax), but the new debug2! macros don't involve allocating at all (unless the formatter for a type requires allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lifts various restrictions on the runtime, for example the character limit
when logging a message. Right now the old debug!-style macros still involve
allocating (because they use fmt! syntax), but the new debug2! macros don't
involve allocating at all (unless the formatter for a type requires allocation.