-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Inline DefId hash implementation #92299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit f3bc691 with merge d52873c4b4735d19734217675f1f504486556bb4... |
☀️ Try build successful - checks-actions |
Queued d52873c4b4735d19734217675f1f504486556bb4 with parent f8abed9, future comparison URL. |
Finished benchmarking commit (d52873c4b4735d19734217675f1f504486556bb4): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Hmm, I suppose that with LTO, the function was inlined anyway, so there's no effect. Closing. |
DefId
recently got a newHash
implementation (#91660). I noticed in profiles that the function was not being inlined. Locally it produced some small gains when I inlined it.