Skip to content

Inline DefId hash implementation #92299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Dec 26, 2021

DefId recently got a new Hash implementation (#91660). I noticed in profiles that the function was not being inlined. Locally it produced some small gains when I inlined it.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 26, 2021
@rust-highfive
Copy link
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2021
@nagisa
Copy link
Member

nagisa commented Dec 27, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 27, 2021
@bors
Copy link
Collaborator

bors commented Dec 27, 2021

⌛ Trying commit f3bc691 with merge d52873c4b4735d19734217675f1f504486556bb4...

@bors
Copy link
Collaborator

bors commented Dec 27, 2021

☀️ Try build successful - checks-actions
Build commit: d52873c4b4735d19734217675f1f504486556bb4 (d52873c4b4735d19734217675f1f504486556bb4)

@rust-timer
Copy link
Collaborator

Queued d52873c4b4735d19734217675f1f504486556bb4 with parent f8abed9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d52873c4b4735d19734217675f1f504486556bb4): comparison url.

Summary: This change led to moderate relevant regressions 😿 in compiler performance.

  • Moderate regression in instruction counts (up to 1.2% on incr-unchanged builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 28, 2021
@Kobzol
Copy link
Contributor Author

Kobzol commented Dec 28, 2021

Hmm, I suppose that with LTO, the function was inlined anyway, so there's no effect. Closing.

@Kobzol Kobzol closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants