Generate random big integers within a range #9133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @huonw would want to take a look at this, considering it's an extension of a previous PR? |
| if self.data.len() == 0 { return 0; } | ||
| let mut bits = (self.data.len()-1) * BigDigit::bits; | ||
| let mut top_digit = self.data[self.data.len()-1]; | ||
| while top_digit != 0 { |
There was a problem hiding this comment.
I believe this can be done with BigDigit::bits - top_digit.leading_zeros(); leading_zeros comes from std::num::BitCount if you need to import it.
|
As one final small nit, would you mind squashing these commits all into one? Also feel free to comment when done, because sadly github doesn't send any notifications when you rebase the branch. Thanks! |
|
Squashed rebase has been pushed. |
|
Did you close this on purpose? It hasn't landed yet. |
|
No it wasn't on purpose. I think github did it automatically when I deleted my branch on github. |
Thanks to @huonw for feedback
|
I also noticed that I forgot to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.