-
Notifications
You must be signed in to change notification settings - Fork 13.3k
track_caller for slice length assertions #90306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 90ea93b with merge 8009f83223e622efca45794a43b6b2a3c67fc8f9... |
☀️ Try build successful - checks-actions |
Queued 8009f83223e622efca45794a43b6b2a3c67fc8f9 with parent 3c8f001, future comparison URL. |
Finished benchmarking commit (8009f83223e622efca45794a43b6b2a3c67fc8f9): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 90ea93b has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0a09858): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
clone_from_slice
was missing#[track_caller]
, and its assert did not report a useful location.These are small generic methods, so hopefully track_caller gets inlined into nothingness, but it may be worth running a benchmark on this.