Skip to content

track_caller for slice length assertions #90306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Oct 26, 2021

clone_from_slice was missing #[track_caller], and its assert did not report a useful location.

These are small generic methods, so hopefully track_caller gets inlined into nothingness, but it may be worth running a benchmark on this.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2021
@the8472
Copy link
Member

the8472 commented Oct 26, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 26, 2021
@bors
Copy link
Collaborator

bors commented Oct 26, 2021

⌛ Trying commit 90ea93b with merge 8009f83223e622efca45794a43b6b2a3c67fc8f9...

@bors
Copy link
Collaborator

bors commented Oct 26, 2021

☀️ Try build successful - checks-actions
Build commit: 8009f83223e622efca45794a43b6b2a3c67fc8f9 (8009f83223e622efca45794a43b6b2a3c67fc8f9)

@rust-timer
Copy link
Collaborator

Queued 8009f83223e622efca45794a43b6b2a3c67fc8f9 with parent 3c8f001, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8009f83223e622efca45794a43b6b2a3c67fc8f9): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 26, 2021
@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 28, 2021
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 30, 2021

📌 Commit 90ea93b has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2021
@bors
Copy link
Collaborator

bors commented Oct 31, 2021

⌛ Testing commit 90ea93b with merge 0a09858...

@bors
Copy link
Collaborator

bors commented Oct 31, 2021

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing 0a09858 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 31, 2021
@bors bors merged commit 0a09858 into rust-lang:master Oct 31, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 31, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0a09858): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@kornelski kornelski deleted the slicecloneasset branch October 10, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants