Convert between BigInts, BigUints, ints, and uints #9014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm hesitant about negative BigInts going to zero. Maybe it should return an Option instead? |
|
I did wonder somewhat about that, but chose to copy what's done in |
|
The |
Previously, conversion to ints, uints, and BigUints clamped the value within the range of that datatype. With this commit, conversion overflows fail the task. To handle overflows gracefully, use the new to_*_opt() methods.
bors
added a commit
that referenced
this pull request
Sep 11, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
…, r=dswij Fix `extra_unused_lifetimes` false positive This PR fixes rust-lang#9014. I confirmed the FP on the `crates.io` source as `@JohnTitor` mentioned, and confirmed that the FP is no longer present following this change. I did not include a test in this PR because I think constructing one would be complicated, and the fix is pretty simple. But please let me know if this is unacceptable. changelog: fix `extra_unused_lifetimes` FP
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
This commit adds test for a `extra_unused_lifetimes` false positive from derive (rust-lang#9014). The fix for the FP is introduced in rust-lang#9037.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
`extra_unused_lifetimes` add FP test case emitting from derived attributes. Add test to cover for rust-lang#9014 which is fixed in rust-lang#9037. changelog: [`extra_unused_lifetimes`] Add FP test case emitting from derived attributes. --- Seeing the FP from the test: ```sh $ git revert -m 1 1d1ae10 $ TESTNAME=extra_unused_lifetime cargo uitest ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.