Skip to content

some clippy::perf fixes #89644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2021
Merged

some clippy::perf fixes #89644

merged 1 commit into from
Oct 8, 2021

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2021
@jyn514
Copy link
Member

jyn514 commented Oct 8, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 8, 2021

📌 Commit ff6601e has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2021
@Mark-Simulacrum
Copy link
Member

@bors rollup=never

This is explicitly perf sensitive...

@bors
Copy link
Collaborator

bors commented Oct 8, 2021

⌛ Testing commit ff6601e with merge 87df4dd...

@bors
Copy link
Collaborator

bors commented Oct 8, 2021

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 87df4dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2021
@bors bors merged commit 87df4dd into rust-lang:master Oct 8, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 8, 2021
@klensy
Copy link
Contributor

klensy commented Oct 9, 2021

Why there no perf-run-on-merge? Queue looks empty.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (87df4dd): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Mark-Simulacrum
Copy link
Member

Manually did it for this PR, but should be fixed by rust-lang/rustc-perf#1066. In the future, please report any issues on rust-lang/rustc-perf so that we can make sure they're fixed; comments on PRs can easily get lost.

@matthiaskrgr matthiaskrgr deleted the clippy_perf_okt branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
9 participants
@matthiaskrgr @rust-highfive @jyn514 @bors @Mark-Simulacrum @klensy @rust-timer @wesleywiser @rustbot