Test and document escaping on format!() #8942
Conversation
| @@ -308,6 +308,13 @@ For integral types, this has no meaning currently. | |||
| For floating-point types, this indicates how many digits after the decimal point | |||
| should be printed. | |||
|
|
|||
| ## Escaping | |||
|
|
|||
| The literal characters '{' or '}' may be included in a string by | |||
There was a problem hiding this comment.
This actually isn't entirely true. The # character also must be escaped (it's a back-reference to the currently-being-formatted argument in nested functions.
|
That looks good to me. Two requests:
|
|
Done. In general, when editing pull requests to rust, should I squash as I go? Or does that get annoying for commenters whose comments get hidden away? (I'm happy to work either way; I just want to make everyone else happy too!) |
|
I don't think there's really a good convention on it one way or another. I've never been that impressed with github's code review tools. It's unfortunate that all history is lost in the github review if you rebase, but I generally think that it's fine to rebase. Thankfully if you do comment on the commit itself github still marks the old comments with "show outdated diff", so at least there's a small consolation. If you comment on the overall pull request diff though I have absolutely no idea what github does to track those between revisions. Anyway, thanks for putting up with me :) |
Rustup r? `@ghost` changelog: none
No description provided.