Update polonius-engine to 0.13.0
#87738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update fact generation to the new relation names
These 2 tests are ignored in the NLL compare-mode, and are ignored in the polonius compare-mode for the same reasons.
These are all about reaching some type and recursion limits and saving the full type in a file, whose folder changes in this compare-mode.
The error output is now the same as the others, no need to bless anything.
Only some simple diagnostic changes happened, and rustfmt-ing.
The diagnostics are different from the NLL ones but the same errors are emitted.
The diagnostics are either the same or better than NLLs: an error that is seen in the compare-mode, but not visible in the NLL output (probably because of early return in case of error) is visible in the polonius output. A duplicate error is emitted because of a suggestion on the universal regions.
This test is ignored in the NLL compare-mode and manually checks the NLL output. This makes the polonius compare-mode fail, even though the output is the same as NLL.
Polonius also emits the error that NLL doesn't get a chance to: see comment "Borrowck doesn't get a chance to run, but if it did it should error here."
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit f2a4d7f has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the use of
polonius-engineto the recently released 0.13.0:Hybridvariant can be the rustc default once againIn particular:
A few tests in the compare-mode still are super slow and trigger the 60s warning, or OOM rustc during fact generation, and I've detailed these on Zulip:
src/test/ui/numbers-arithmetic/saturating-float-casts.rs-> OOM during rustc fact generationsrc/test/ui/numbers-arithmetic/num-wrapping.rssrc/test/ui/issues/issue-72933-match-stack-overflow.rssrc/test/ui/issues/issue-74564-if-expr-stack-overflow.rssrc/test/ui/repr/repr-no-niche.rsIn addition, 2 tests don't currently pass and I didn't want to bless them now: they deal with HRTBs and miss errors that NLLs emit. We're currently trying to see if we need chalk to deal with HRTB errors (as we thought we would have to) but during the recent sprint, we discovered that we may be able to detect some of these errors in a way that resembles subset errors:
ui/hrtb/hrtb-just-for-static.rs-> 3 errors in NLL, 2 in polonius: a missing error about HRTB + needing to outlive 'staticui/issues/issue-26217.rs-> missing HRTB that makes the test compile instead of emitting an errorWe'll keep talking about this at the next sprint as well.
cc @rust-lang/wg-polonius r? @nikomatsakis