Fix some vector function failure tests. Closes #8698 #8701
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase (already!) |
bors
added a commit
that referenced
this pull request
Aug 25, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…=flip1995
Rework `#[clippy::dump]` attribute for debugging
Hey `@rust-lang/clippy,` this adds a new `#[clippy::print_hir]` attribute that prints the node to the console using `{:#?}`. Personally, I use print debugging quite a lot while working on Clippy, and this is a simple shortcut that also works in the playground (Once this has been synced). The question is now, if we want to have this attribute. Are there any concerns? I think it's similar to our `#[clippy::author]` attribute.
I haven't added a test, as the `.stdout` file would require updates with every HIR change inside rustc. Here are some examples, for the current implementation
<details>
<summary>`do_something(&map);`</summary>
```rs
Expr {
hir_id: HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 21,
},
kind: Call(
Expr {
hir_id: HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 17,
},
kind: Path(
Resolved(
None,
Path {
span: tests/ui/aaa.rs:23:5: 23:17 (#0),
res: Def(
Fn,
DefId(0:6 ~ aaa[995b]::do_something),
),
segments: [
PathSegment {
ident: do_something#0,
hir_id: Some(
HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 16,
},
),
res: Some(
Err,
),
args: None,
infer_args: true,
},
],
},
),
),
span: tests/ui/aaa.rs:23:5: 23:17 (#0),
},
[
Expr {
hir_id: HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 20,
},
kind: AddrOf(
Ref,
Not,
Expr {
hir_id: HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 19,
},
kind: Path(
Resolved(
None,
Path {
span: tests/ui/aaa.rs:23:19: 23:22 (#0),
res: Local(
HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 15,
},
),
segments: [
PathSegment {
ident: map#0,
hir_id: Some(
HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 18,
},
),
res: Some(
Local(
HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 15,
},
),
),
args: None,
infer_args: true,
},
],
},
),
),
span: tests/ui/aaa.rs:23:19: 23:22 (#0),
},
),
span: tests/ui/aaa.rs:23:18: 23:22 (#0),
},
],
),
span: tests/ui/aaa.rs:23:5: 23:23 (#0),
}
```
</details>
<details>
<summary>`use std::collections::HashMap;`</summary>
```rs
Item {
ident: HashMap#0,
def_id: DefId(0:5 ~ aaa[995b]::{misc#1}),
kind: Use(
Path {
span: tests/ui/aaa.rs:8:5: 8:30 (#0),
res: Def(
Struct,
DefId(1:1294 ~ std[928b]::collections::hash::map::HashMap),
),
segments: [
PathSegment {
ident: std#0,
hir_id: Some(
HirId {
owner: DefId(0:5 ~ aaa[995b]::{misc#1}),
local_id: 1,
},
),
res: Some(
Def(
Mod,
DefId(1:0 ~ std[928b]),
),
),
args: None,
infer_args: false,
},
PathSegment {
ident: collections#0,
hir_id: Some(
HirId {
owner: DefId(0:5 ~ aaa[995b]::{misc#1}),
local_id: 2,
},
),
res: Some(
Def(
Mod,
DefId(1:1193 ~ std[928b]::collections),
),
),
args: None,
infer_args: false,
},
PathSegment {
ident: HashMap#0,
hir_id: Some(
HirId {
owner: DefId(0:5 ~ aaa[995b]::{misc#1}),
local_id: 3,
},
),
res: Some(
Err,
),
args: None,
infer_args: false,
},
],
},
Single,
),
vis: Spanned {
node: Inherited,
span: tests/ui/aaa.rs:8:1: 8:1 (#0),
},
span: tests/ui/aaa.rs:8:1: 8:31 (#0),
}
```
</details>
<details>
<summary>`"100"`</summary>
```rs
Expr {
hir_id: HirId {
owner: DefId(0:7 ~ aaa[995b]::main),
local_id: 27,
},
kind: Lit(
Spanned {
node: Str(
"100",
Cooked,
),
span: tests/ui/aaa.rs:28:9: 28:14 (#0),
},
),
span: tests/ui/aaa.rs:28:9: 28:14 (#0),
}
```
</details>
---
changelog: Added `[clippy::print_hir]` to inspect rustc's internal representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.