Assorted small bugfixes. #8677
Closed
Assorted small bugfixes. #8677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| macro_rules! assert_once_ever( | ||
| ($( $msg:expr),+) => ( { | ||
| // FIXME(#8472) extra function should not be needed to hide unsafe | ||
| fn assert_once_ever() { |
There was a problem hiding this comment.
This presumably breaks if it's used twice?
There was a problem hiding this comment.
(Wait, I see, it's got an inner block so the fn is scoped within it.)
There was a problem hiding this comment.
yeah, macro hygiene saves the day
bors
added a commit
that referenced
this pull request
Aug 23, 2013
r anybody; there isn't anything complicated here
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…r=giraffate Add `usize` cast to `clippy::manual_bits` suggestion A fix for the suggestion from rust-lang/rust-clippy#8213 changelog: [`manual_bits`]: The suggestion now includes a cast for proper type conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r anybody; there isn't anything complicated here