-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Generalize and inline slice::fill specializations #83245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Odd, this didn't show up when running tidy locally. |
This should also improve cross-crate inlining since the method is generic
9a25668
to
d7fdd90
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit d7fdd90 with merge ce671292e8a00a0c94483a1fe89485bb08d4762b... |
☀️ Try build successful - checks-actions |
Queued ce671292e8a00a0c94483a1fe89485bb08d4762b with parent 36f1f04, future comparison URL. |
Finished benchmarking try commit (ce671292e8a00a0c94483a1fe89485bb08d4762b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@rustbot label T-libs-impl |
Thanks! @bors r+ |
📌 Commit d7fdd90 has been approved by |
☀️ Test successful - checks-actions |
This makes the memset specialization applicable to more types. And since the code now lives in a generic method it is also eligible for cross-crate inlining which should fix #83235