Assorted iterator fixes in libstd #8265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
src/libstd/option.rs
Outdated
There was a problem hiding this comment.
To follow the pattern of HashMap, could this be called consume?
There was a problem hiding this comment.
Well I don't agree -- there are still many consume_iter around too -- but that's just how my mind is set.
|
Thanks for the comments! Updated to address them. I removed the commit to remove uint::iterate because it conflicts with the snapshot PR. |
|
|
|
uint::iterate removal is back, because the snapshot landed. |
|
Rebased. Still a branch of "assorted changes", I'm happy to hear if this can go in, or what can be improved. |
|
I guess it will conflict with the std::result PR |
added 12 commits
August 6, 2013 03:59
Let Option be a base for a widely useful one- or zero- item iterator. Refactor OptionIterator to support any generic element type, so the same iterator impl can be used for both &T, &mut T and T iterators.
convert iter() and iter_err() for Result. Use OptionIterator.
Implement clone, bidirectionality and random access for this iterator
Use the Repeat iterator to carry the "explicit closure capture" that was previously done with the custom EnvFilterIterator.
With Option as the simplest container, `consume` is the way to turn it into a by-value iterator.
ChunkIter .idx() didn't handle overflow correctly, even though it tried.
bors
added a commit
that referenced
this pull request
Aug 6, 2013
Fix #8228 by replacing .iter() and .iter_err() in Result by external iterators. Implement random access for `iterator::Invert` and `vec::ChunkIter` (and bidirectionality). Implement Repeat iterator.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 13, 2022
Cache rustfmt path changelog: none Call `rustup which rustfmt` and use the output. This shaves off ~0.7 seconds for `cargo dev fmt` for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8228 by replacing .iter() and .iter_err() in Result by external iterators.
Implement random access for
iterator::Invertandvec::ChunkIter(and bidirectionality).Implement Repeat iterator.