Suggest renaming or escaping when fixing non-snake-case identifiers which would conflict with keywords #80592
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| LL | let Super: usize = 0; | ||
| | ^^^^^ help: rename the identifier |
There was a problem hiding this comment.
It may be helpful to emit a note along the lines of super cannot be used as a raw identifier in this case so the user doesn't fruitlessly try to do so.
There was a problem hiding this comment.
Good idea, thanks! Added in 750c52a
|
@bors r+ |
|
📌 Commit 750c52a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
I just want to point out I'm amazing at the turnaround on this issue. I filed it after writing throwaway code expecting nobody to touch this for months, and instead there was a fix submitted within a day and it was merged within another day. |
Fixes #80575