Improve wording of flatten() docs
#79925
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
A-iterators
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 97cd55e has been approved by |
bors
added
S-waiting-on-bors
pickfire
reviewed
Dec 11, 2020
| @@ -1332,7 +1332,7 @@ pub trait Iterator { | |||
| /// assert_eq!(merged, "alphabetagamma"); | |||
| /// ``` | |||
| /// | |||
| /// Flattening once only removes one level of nesting: | |||
| /// Flattening only removes one level of nesting at a time: | |||
There was a problem hiding this comment.
Suggested change
| /// Flattening only removes one level of nesting at a time: | |
| /// Flattening only removes one level of nesting once: |
"at a time" is not clear that it happened once, feels like a play a words, people may not notice it if not careful. Oh, after reading it I find it being extra, we can even remove "at a time" or "once".
Flattening only removes one level of nesting
I think would be clear enough.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.