Skip to content

⬆️ rust-analyzer #75631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

⬆️ rust-analyzer #75631

merged 1 commit into from
Aug 18, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 17, 2020

r? @ghost

@matklad
Copy link
Member Author

matklad commented Aug 17, 2020

bors r+

@matklad
Copy link
Member Author

matklad commented Aug 17, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 17, 2020

📌 Commit 0c33df9 has been approved by matklad

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 17, 2020
@jonas-schievink
Copy link
Contributor

@bors rollup=never

@tmandry
Copy link
Member

tmandry commented Aug 18, 2020

What's the actual reason to use rollup=never? This doesn't affect toolstate or perf, as far as I know.

@matklad
Copy link
Member Author

matklad commented Aug 18, 2020

So far, success rate for “update ra” PRs is less than 50%, so rolllups are risky.

The last three failures were:

  • fail to compile on 32bit power which doesn’t have AromicU64
  • trip LLVM assertion on 32bit riscv
  • fail to compile on Linux musl, which doesn’t have Glibc function we were using

@bors
Copy link
Collaborator

bors commented Aug 18, 2020

⌛ Testing commit 0c33df9 with merge 01ffbcb...

@bors
Copy link
Collaborator

bors commented Aug 18, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matklad
Pushing 01ffbcb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2020
@bors bors merged commit 01ffbcb into rust-lang:master Aug 18, 2020
@matklad matklad deleted the rust-analyzer-2020-08-17 branch August 18, 2020 13:48
@bjorn3 bjorn3 mentioned this pull request Aug 18, 2020
Closed
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matklad @bors @jonas-schievink @tmandry @cuviper