Skip to content

Fix/annotate a variety of xfail'd tests #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/test/run-pass/autoderef-method-priority.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// xfail-test
// xfail'd because of a problem with by-value self.

// xfail-test #5321
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
Expand Down
60 changes: 0 additions & 60 deletions src/test/run-pass/class-cast-to-trait-cross-crate.rs

This file was deleted.

2 changes: 1 addition & 1 deletion src/test/run-pass/class-impl-parameterized-trait.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #7307
// xfail-fast

extern mod extra;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/class-implements-multiple-traits.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #7305

extern mod extra;
use extra::oldmap::*;
Expand Down
35 changes: 0 additions & 35 deletions src/test/run-pass/class-trait-bounded-param.rs

This file was deleted.

4 changes: 2 additions & 2 deletions src/test/run-pass/coerce-reborrow-imm-vec-arg.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// xfail-test

fn sum(x: &[int]) -> int {
let mut sum = 0;
for x.each |y| { sum += *y; }
Expand All @@ -14,8 +12,10 @@ fn sum_imm(y: &[int]) -> int {
sum(y)
}

/* FIXME #7304
fn sum_const(y: &const [int]) -> int {
sum(y)
}
*/

pub fn main() {}
18 changes: 9 additions & 9 deletions src/test/run-pass/coerce-reborrow-imm-vec-rcvr.rs
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
// xfail-test

/* FIXME #7302
fn foo(v: &const [uint]) -> ~[uint] {
v.to_vec()
v.to_owned()
}
*/

fn bar(v: &mut [uint]) -> ~[uint] {
v.to_vec()
v.to_owned()
}

fn bip(v: &[uint]) -> ~[uint] {
v.to_vec()
v.to_owned()
}

pub fn main() {
let mut the_vec = ~[1, 2, 3, 100];
assert_eq!(the_vec, foo(the_vec));
assert_eq!(the_vec, bar(the_vec));
assert_eq!(the_vec, bip(the_vec));
let mut the_vec = ~[1u, 2, 3, 100];
// assert_eq!(the_vec.clone(), foo(the_vec));
assert_eq!(the_vec.clone(), bar(the_vec));
assert_eq!(the_vec.clone(), bip(the_vec));
}
2 changes: 1 addition & 1 deletion src/test/run-pass/deriving-global.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// xfail-test #7103 `extern mod` does not work on windows
// xfail-fast #7103 `extern mod` does not work on windows

// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
Expand Down
4 changes: 2 additions & 2 deletions src/test/run-pass/extern-mod-url.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// Just a test that new-style extern mods parse

// xfail-test
// xfail-test FIXME #6407
extern mod test = "github.com/catamorphism/test-pkg";

fn main() {}
fn main() {}
7 changes: 2 additions & 5 deletions src/test/run-pass/fn-bare-size.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test

extern mod extra;
use std::sys;

pub fn main() {
// Bare functions should just be a pointer
assert!(sys::rustrt::size_of::<fn()>() ==
sys::rustrt::size_of::<int>());
assert_eq!(sys::size_of::<extern "Rust" fn()>(), sys::size_of::<int>());
}
2 changes: 1 addition & 1 deletion src/test/run-pass/foreign-mod.rc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #7308
// -*- rust -*-

native mod libc = target_libc {
Expand Down
4 changes: 3 additions & 1 deletion src/test/run-pass/issue-1866.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #1866
mod a {
pub type rust_task = uint;
pub mod rustrt {
use super::rust_task;
pub extern {
pub fn rust_task_is_unwinding(rt: *rust_task) -> bool;
}
Expand All @@ -21,6 +22,7 @@ mod a {
mod b {
pub type rust_task = bool;
pub mod rustrt {
use super::rust_task;
pub extern {
pub fn rust_task_is_unwinding(rt: *rust_task) -> bool;
}
Expand Down
30 changes: 0 additions & 30 deletions src/test/run-pass/issue-2101.rs

This file was deleted.

20 changes: 10 additions & 10 deletions src/test/run-pass/issue-2190-2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,23 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #2190
mod a {
fn foo(f: &fn()) { f() }
fn bar() {}
pub fn main() { foo(||bar()); }
fn foo(f: &fn()) { f() }
fn bar() {}
pub fn main() { foo(||bar()); }
}

mod b {
fn foo(f: Option<&fn()>) { f.iter(|x|x()) }
fn bar() {}
pub fn main() { foo(Some(bar)); }
fn foo(f: Option<&fn()>) { f.iter(|x|x()) }
fn bar() {}
pub fn main() { foo(Some(bar)); }
}

mod c {
fn foo(f: Option<&fn()>) { f.iter(|x|x()) }
fn bar() {}
pub fn main() { foo(Some(||bar())); }
fn foo(f: Option<&fn()>) { f.iter(|x|x()) }
fn bar() {}
pub fn main() { foo(Some(||bar())); }
}

pub fn main() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-3290.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #3290
fn main() {
let mut x = ~3;
x = x;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-3796.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #3796
#[deny(dead_assignment)];
fn main() {
let mut x = 1;
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-3874.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #3874
enum PureCounter { PureCounter(uint) }

fn each(self: PureCounter, blk: &fn(v: &uint)) {
Expand Down
7 changes: 4 additions & 3 deletions src/test/run-pass/issue-3979-2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,17 @@
// except according to those terms.

// xfail-test

trait A {
fn a_method();
fn a_method(&self);
}

trait B: A {
fn b_method();
fn b_method(&self);
}

trait C: B {
fn c_method() {
fn c_method(&self) {
self.a_method();
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass/issue-3979-generics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
// xfail-test FIXME #5946
trait Positioned<S> {
fn SetX(&mut self, S);
fn X(&self) -> S;
Expand Down
6 changes: 4 additions & 2 deletions src/test/run-pass/issue-4241.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
extern mod extra;

use extra::net::tcp::TcpSocketBuf;

use std::io;
use std::int;

use std::io::{ReaderUtil,WriterUtil};

enum Result {
Expand Down Expand Up @@ -99,7 +101,7 @@ priv fn cmd_to_str(cmd: ~[~str]) -> ~str {
res.push_str("\r\n");
for cmd.each |s| {
res.push_str([~"$", s.len().to_str(), ~"\r\n",
copy *s, ~"\r\n"].concat()));
copy *s, ~"\r\n"].concat() );
}
res
}
Expand Down
3 changes: 2 additions & 1 deletion src/test/run-pass/issue-4541.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-test
use std::io;

fn parse_args() -> ~str {
let args = std::os::args();
let mut n = 0;
Expand Down
Loading