Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

estebank and others added 15 commits April 17, 2020 09:59
These were all build-pass before and don't seem to need it.

Helps with rust-lang#62277
Remove unused rustc_serialize::hex module

* Remove unused `rustc_serialize::hex` module
* Cleanup `Cargo.toml`
…laumeGomez

Moving all rustdoc-ui tests to check-pass

These were all build-pass before and don't seem to need it.

Helps with rust-lang#62277

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rust-lang/rust/71337)
<!-- Reviewable:end -->
Use assoc int consts3

Define module level int consts with associated constants instead of `min_value()` and `max_value()`. So the code become consistent with what the docs recommend etc. Seems natural.

Also remove the last usages of the int module constants from this repo (except src/test/ directory which I have still not really done anything in). Some places were missed in the previous PRs because the code uses `crate::<IntTy>` to reach the constants.

This is a continuation of rust-lang#70857

r? @dtolnay
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

📌 Commit 7f3250a has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2020
@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 7f3250a with merge 7584a204e75a084b3d8f0ad0298c7e220bf50860...

@Dylan-DPC-zz
Copy link
Author

@bors retry (Yielding to beta)

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 7f3250a with merge 8ea7216b116e0701ca6f5c8ce932d4e064f8552a...

@Dylan-DPC-zz
Copy link
Author

@bors retry

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 7f3250a with merge 43bd143921b6f43782d3d0383b495e430e9c422f...

@Dylan-DPC-zz
Copy link
Author

@bors retry yield

@bors
Copy link
Collaborator

bors commented Apr 21, 2020

⌛ Testing commit 7f3250a with merge 54a9013e30e719a47a3dfeb8c01b267d5c5afe1d...

@JohnTitor JohnTitor added the rollup A PR which is a rollup label Apr 22, 2020
@bors
Copy link
Collaborator

bors commented Apr 22, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2020
@JohnTitor JohnTitor closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants