Make process_obligations() greedier.
#66408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@nikomatakis: I'm not 100% confident about the Some local instruction count measurements: |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
bors
added a commit
that referenced
this pull request
Nov 14, 2019
Make `process_obligations()` greedier. `process_obligations()` adds new nodes, but it does not process these new nodes until the next time it is called. This commit changes it so that it does process these new nodes within the same call. This change reduces the number of calls to `process_obligations()` required to complete processing, sometimes giving significant speed-ups. The change required some changes to tests. - The output of `cycle-cache-err-60010.rs` is slightly different. - The unit tests required extra cases to handle the earlier processing of the added nodes. I mostly did these in the simplest possible way, by making the added nodes be ignored, thus giving outcomes the same as with the old behaviour. But I changed `success_in_grandchildren()` more extensively so that some obligations are completed earlier than they used to be. r? @nikomatsakis
hellow554
reviewed
Nov 14, 2019
|
☀️ Try build successful - checks-azure |
|
Queued f988482 with parent 5e380b7, future comparison URL. |
|
The perf improvements on CI are similar to what I saw locally. |
`process_obligations()` adds new nodes, but it does not process these new nodes until the next time it is called. This commit changes it so that it does process these new nodes within the same call. This change reduces the number of calls to `process_obligations()` required to complete processing, sometimes giving significant speed-ups. The change required some changes to tests. - The output of `cycle-cache-err-60010.rs` is slightly different. - The unit tests required extra cases to handle the earlier processing of the added nodes. I mostly did these in the simplest possible way, by making the added nodes be ignored, thus giving outcomes the same as with the old behaviour. But I changed `success_in_grandchildren()` more extensively so that some obligations are completed earlier than they used to be.
nnethercote
force-pushed
the
greedy-process_obligations
branch
from
98a7454 to
05f13a8
Compare
|
Ping from triage |
nikomatsakis
approved these changes
Dec 2, 2019
nikomatsakis
requested changes
Dec 2, 2019
There was a problem hiding this comment.
r=me modulo nit below -- @nnethercote if you hate it you can also ignore, but it seems like a slight improvement to me
|
@bors r=nmatsakis |
|
📌 Commit 05f13a8 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never |
|
⌛ Testing commit 05f13a8 with merge 0ecfb9332bac36049d7e9a3acfc41df2deadc5dd... |
|
@bors retry yielding to r0llup |
bors
added a commit
that referenced
this pull request
Dec 4, 2019
…sakis Make `process_obligations()` greedier. `process_obligations()` adds new nodes, but it does not process these new nodes until the next time it is called. This commit changes it so that it does process these new nodes within the same call. This change reduces the number of calls to `process_obligations()` required to complete processing, sometimes giving significant speed-ups. The change required some changes to tests. - The output of `cycle-cache-err-60010.rs` is slightly different. - The unit tests required extra cases to handle the earlier processing of the added nodes. I mostly did these in the simplest possible way, by making the added nodes be ignored, thus giving outcomes the same as with the old behaviour. But I changed `success_in_grandchildren()` more extensively so that some obligations are completed earlier than they used to be. r? @nikomatsakis
|
☀️ Test successful - checks-azure |
This was referenced Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_obligations()adds new nodes, but it does not process thesenew nodes until the next time it is called.
This commit changes it so that it does process these new nodes within
the same call. This change reduces the number of calls to
process_obligations()required to complete processing, sometimesgiving significant speed-ups.
The change required some changes to tests.
cycle-cache-err-60010.rsis slightly different.of the added nodes. I mostly did these in the simplest possible way,
by making the added nodes be ignored, thus giving outcomes the same as
with the old behaviour. But I changed
success_in_grandchildren()more extensively so that some obligations are completed earlier than
they used to be.
r? @nikomatsakis