Derive TypeFoldable using a proc-macro #66384
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/librustc/ty/context.rs
Outdated
| @@ -307,7 +307,8 @@ pub struct ResolvedOpaqueTy<'tcx> { | |||
| /// | |||
| /// Here, we would store the type `T`, the span of the value `x`, and the "scope-span" for | |||
| /// the scope that contains `x`. | |||
| #[derive(RustcEncodable, RustcDecodable, Clone, Debug, Eq, Hash, HashStable, PartialEq)] | |||
| #[derive(RustcEncodable, RustcDecodable, Clone, Debug, Eq, Hash, HashStable, PartialEq, | |||
| TypeFoldable)] | |||
There was a problem hiding this comment.
Maybe we should have two #[derive(...)] attributes, one for the standard derives and one for the rustc-specific derives?
Maybe we could handle those by having |
|
This is awesome. We should definitely do this. |
|
I changed the formatting of the derives. If you don't mind, I would like to keep the Clone-based implementations for another PR. |
|
@cjgillot It's a good idea to keep PR small anyway. Moving |
| } | ||
| }; | ||
| } | ||
|
|
||
| #[macro_export] | ||
| macro_rules! EnumTypeFoldableImpl { |
There was a problem hiding this comment.
It is still used to implement TypeFoldable for types defined in librustc's dependencies.
There was a problem hiding this comment.
Hmm... maybe we should keep the other macros too then since they could also be used for that.
There was a problem hiding this comment.
I wonder if we should just use the derives for all librustc* and libsyntax* crates, even if they don't are/depend on librustc.
There was a problem hiding this comment.
@eddyb As in, add a generic Fold trait for librustc dependencies? That seems maybe too complex. I'm not sure there's many uses of this macro left.
There was a problem hiding this comment.
Oh, right, sorry. What I said makes sense for HashStable but not as much this.
|
@bors r+ |
|
📌 Commit cb46c35 has been approved by |
bors
added
S-waiting-on-bors
Derive TypeFoldable using a proc-macro A new proc macro is added in librustc_macros. It is used to derive TypeFoldable inside librustc and librustc_traits. For now, the macro uses the `'tcx` lifetime implicitly, and does not allow for a more robust selection of the adequate lifetime. The Clone-based TypeFoldable implementations are not migrated. Closes #65674
|
☀️ Test successful - checks-azure |
A new proc macro is added in librustc_macros.
It is used to derive TypeFoldable inside librustc and librustc_traits.
For now, the macro uses the
'tcxlifetime implicitly, and does not allow for a more robust selection of the adequate lifetime.The Clone-based TypeFoldable implementations are not migrated.
Closes #65674