Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 29, 2019

Closes #63694, closes #55619

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2019
@tesuji tesuji force-pushed the new-feature-gate-c_void branch from 2266be4 to 9fcb399 Compare October 29, 2019 12:53
@tesuji tesuji force-pushed the new-feature-gate-c_void branch from 9fcb399 to bc98c86 Compare October 29, 2019 13:02
@Centril
Copy link
Contributor

Centril commented Oct 29, 2019

I know nothing about this :) r? @dtolnay

@rust-highfive rust-highfive assigned dtolnay and unassigned Centril Oct 29, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Oct 29, 2019

r? @SimonSapin

@rust-highfive rust-highfive assigned SimonSapin and unassigned dtolnay Oct 29, 2019
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Oct 29, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 29, 2019

📌 Commit bc98c86 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 29, 2019
…tolnay

doc: use new feature gate for c_void type

Closes rust-lang#63694, closes rust-lang#55619
bors added a commit that referenced this pull request Oct 29, 2019
Rollup of 12 pull requests

Successful merges:

 - #65405 (Create new error E0742 and add long error explanation)
 - #65539 (resolve: Turn the "non-empty glob must import something" error into a lint)
 - #65724 (ci: refactor pr tools job skipping)
 - #65741 (Prevent help popup to disappear when clicking on it)
 - #65832 (Re-enable Emscripten's exception handling support)
 - #65843 (Enable dist for MIPS64 musl targets)
 - #65898 (add basic HermitCore support within libtest)
 - #65900 (proc_macro: clean up bridge::client::__run_expand{1,2} a bit.)
 - #65906 (Update mdbook to 0.3.3)
 - #65920 (Use rustc-workspace-hack for rustbook)
 - #65930 (doc: use new feature gate for c_void type)
 - #65936 (save-analysis: Account for async desugaring in async fn return types)

Failed merges:

 - #65434 (Add long error explanation for E0577)

r? @ghost
@bors bors merged commit bc98c86 into rust-lang:master Oct 29, 2019
@tesuji tesuji deleted the new-feature-gate-c_void branch October 30, 2019 02:17
@dtolnay dtolnay assigned dtolnay and unassigned SimonSapin Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core::ffi::c_void is marked as "stable since 1.1", but it was added in 1.30 c_void has wrong rustc support level in docs
7 participants