Added to_str() method for HashMap and HashSet #6414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Why is the test commented out? |
|
All tests pass with the existing tests. For some reason, I was getting test failures (on the tests I wrote myself). I compiled a simple test Rust program and testing hash_table.to_str() works fine. The order in which the elements are accessed is prone to change. I think that is why the test may have failed. I'll try getting the empty HashMap test to pass and recommit. |
…Table doesn't need to be mutable.
| acc | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Change all the ~"foo" to "foo", expect for the initial one.
1. Extra space removed. 2. Using acc.push_str() instead of str::push_str 3. Update test to reflect representation change.
Also added some whitespace to enhance readabilty.
All tests now pass.
All tests pass now.
bors
added a commit
that referenced
this pull request
May 12, 2013
Implemented to_str() for HashMap and HashSet Added tests. Minor formatting and stylistic cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented to_str() for HashMap and HashSet
Added tests.
Minor formatting and stylistic cleanups.