Skip to content

Places drive by cleanups #63874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2019
Merged

Conversation

spastorino
Copy link
Member

Small fixes of things meanwhile I was doing the box part of Place 2.0, based on @Centril reviews.

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2019
@Centril
Copy link
Contributor

Centril commented Aug 25, 2019

r? @Centril @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 25, 2019

📌 Commit 53f4734 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2019
@bors
Copy link
Collaborator

bors commented Aug 25, 2019

⌛ Testing commit 53f4734 with merge d760df5...

bors added a commit that referenced this pull request Aug 25, 2019
Places drive by cleanups

Small fixes of things meanwhile I was doing the box part of Place 2.0, based on @Centril reviews.
@bors
Copy link
Collaborator

bors commented Aug 25, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing d760df5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2019
@bors bors merged commit 53f4734 into rust-lang:master Aug 25, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #63874!

Tested on commit d760df5.
Direct link to PR: #63874

🎉 rustc-guide on linux: test-fail → test-pass (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 25, 2019
Tested on commit rust-lang/rust@d760df5.
Direct link to PR: <rust-lang/rust#63874>

🎉 rustc-guide on linux: test-fail → test-pass (cc @mark-i-m @spastorino @amanjeev, @rust-lang/infra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants