Skip to content

clarify that unchecked indexing is UB even if the reference is never used #63233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2019
Merged

clarify that unchecked indexing is UB even if the reference is never used #63233

merged 3 commits into from
Aug 4, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 3, 2019

No description provided.

@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2019
Centril
Centril reviewed Aug 3, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! r=me rollup with suggestions applied.

@Centril
Copy link
Contributor

Centril commented Aug 3, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned dtolnay Aug 3, 2019
@RalfJung @Centril
Apply suggestions from code review
3b9cda4 
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
@RalfJung
Copy link
Member Author

RalfJung commented Aug 3, 2019

@bors r=Centril rollup

@bors
Copy link
Collaborator

bors commented Aug 3, 2019

📌 Commit 3b9cda4 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

RalfJung commented Aug 3, 2019 •
edited
Loading

@bors r-

investigating

EDIT: fixed links, waiting for PR CI

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

RalfJung commented Aug 4, 2019

Okay I give up, we do indeed have to use an absolute link.

@RalfJung
fix links
9b5623f 
relative links do not work because this is included in several places
@RalfJung
Copy link
Member Author

RalfJung commented Aug 4, 2019

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Aug 4, 2019

📌 Commit 9b5623f has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2019
@bors
Copy link
Collaborator

bors commented Aug 4, 2019

⌛ Testing commit 9b5623f with merge 5170a3f...

bors added a commit that referenced this pull request Aug 4, 2019
@bors
Auto merge of #63233 - RalfJung:get_unchecked, r=Centril
5170a3f 
clarify that unchecked indexing is UB even if the reference is never used
@bors
Copy link
Collaborator

bors commented Aug 4, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 5170a3f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 4, 2019
@bors bors merged commit 9b5623f into rust-lang:master Aug 4, 2019
@RalfJung RalfJung deleted the get_unchecked branch August 5, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rust-highfive @Centril @bors @dtolnay