Skip to content

Do not emit type errors after parse error in last statement of block #62643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

estebank
Copy link
Contributor

When recovering from a parse error inside a block, do not emit type
errors generating on that block's recovered return expression.

Fix #57383.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2019
When recovering from a parse error inside a block, do not emit type
errors generating on that block's recovered return expression.

Fix rust-lang#57383.
@estebank estebank force-pushed the parse-recovery-type-errs branch from 0809683 to 8259a2d Compare July 13, 2019 01:55
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 14, 2019

📌 Commit 8259a2d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2019
@bors
Copy link
Collaborator

bors commented Jul 14, 2019

⌛ Testing commit 8259a2d with merge d82fd9e...

bors added a commit that referenced this pull request Jul 14, 2019
Do not emit type errors after parse error in last statement of block

When recovering from a parse error inside a block, do not emit type
errors generating on that block's recovered return expression.

Fix #57383.
@bors
Copy link
Collaborator

bors commented Jul 15, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: petrochenkov
Pushing d82fd9e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 15, 2019
@bors bors merged commit 8259a2d into rust-lang:master Jul 15, 2019
@estebank estebank deleted the parse-recovery-type-errs branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not emit type error after parse error in last statement of block
4 participants