Skip to content

libcore: Export core::from_str::FromStr from core::prelude #6185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2013
Merged

libcore: Export core::from_str::FromStr from core::prelude #6185

merged 2 commits into from
May 3, 2013

Conversation

gifnksm
Copy link
Contributor

@gifnksm gifnksm commented May 2, 2013

core::prelude re-exports core::to_str::ToStr, but doesn't re-export core::from_str::FromStr.
That is inconsistent.

@thestinger
Copy link
Contributor

I don't think you need the $[cfg(stage0)] attributes on the FromStr use statements. AFAIK changes to core don't need to worry about the stages because the snapshot compiler starts off by compiling libcore.

@gifnksm
Copy link
Contributor Author

gifnksm commented May 3, 2013

@thestinger yes, you are right. I've misunderstood the stages.
I removed extra #[cfg(stage0)]s in e34a7ec.

bors added a commit that referenced this pull request May 3, 2013
@bors
auto merge of #6185 : gifnksm/rust/prelude-from_str, r=graydon
d9c7d0b 
`core::prelude`  re-exports `core::to_str::ToStr`, but doesn't re-export `core::from_str::FromStr`.
That is inconsistent.
@bors bors closed this May 3, 2013
@bors bors merged commit e34a7ec into rust-lang:incoming May 3, 2013
@gifnksm gifnksm deleted the prelude-from_str branch May 4, 2013 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gifnksm @thestinger @bors