make way for a new iter module #6056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I feel ill-equipped to review what's going on in the iteration-protocols area. Do you have a rough plan? Could you write it up somewhere? I realize this sounds foot-draggy but we have reinvented stuff in this space a number of times and I want to make sure we're getting closer-to-done :) |
Contributor
Author
|
@graydon: I did a write-up of the plan at https://github.com/mozilla/rust/wiki/Iterators Some of that is included as the docstring in the new |
Contributor
|
needs a rebase, sadly. r+ otherwise! |
bors
added a commit
that referenced
this pull request
Apr 29, 2013
The existing adaptors like `map` in the `iter` module are very flawed because they only work for `BaseIter` implementations. There are many internal iterator implementations in the standard library like the set methods (`difference`, `symmetric_difference`, `intersection`, `union`) and the `range` functions that only share the `for` loop protocol in common. The internal iterator adaptors should be implemented to work on any implementation of that protocol, rather than just a method called `each` taking `&self`. This just moves `iter.rs` to `old_iter.rs` and begins work on documenting and implementing a nicer module.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 24, 2020
Add S-* label modifier to triagebot changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing adaptors like
mapin theitermodule are very flawed because they only work forBaseIterimplementations. There are many internal iterator implementations in the standard library like the set methods (difference,symmetric_difference,intersection,union) and therangefunctions that only share theforloop protocol in common.The internal iterator adaptors should be implemented to work on any implementation of that protocol, rather than just a method called
eachtaking&self.This just moves
iter.rstoold_iter.rsand begins work on documenting and implementing a nicer module.