libprofiler_builtins: Set compilation flags more correctly for C code. #60402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit d52fde2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 30, 2019
…-build, r=alexcrichton libprofiler_builtins: Set compilation flags more correctly for C code. In particular, set `COMPILER_RT_HAS_FCNTL_LCK` and `COMPILER_RT_HAS_ATOMICS` as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries. The build script is using a heuristic here that hopefully is sufficient for the time being. r? @alexcrichton Fixes rust-lang#59531.
|
Failed in #60420 (comment) . |
rustbot
added
S-waiting-on-author
|
@bors r- ^ |
michaelwoerister
force-pushed
the
update-profiler-rt-build
branch
from
d52fde2 to
d4dfbeb
Compare
|
Typo fixed. @bors r=alexcrichton |
|
📌 Commit d4dfbeb has been approved by |
bors
added
S-waiting-on-bors
16 tasks
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 2, 2019
…-build, r=alexcrichton libprofiler_builtins: Set compilation flags more correctly for C code. In particular, set `COMPILER_RT_HAS_FCNTL_LCK` and `COMPILER_RT_HAS_ATOMICS` as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries. The build script is using a heuristic here that hopefully is sufficient for the time being. r? @alexcrichton Fixes rust-lang#59531.
|
⌛ Testing commit d4dfbeb with merge c3b08da044476a942cf78b3b4fc67d943a5890be... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
I was able reproduce this locally. It seems that Clang 7 can't handle some of the C instrinsics for Arm64 Windows yet. Switching to Clang 8 fixes the problem. @rust-lang/infra, how would I update the clang version defined here? Lines 152 to 164 in 55c48b4 |
|
Ok I've uploaded the 8.0.0 binary to our CI bucket, if you update s/7/8/g here I think it should work |
|
❤️ |
In particular, set COMPILER_RT_HAS_FCNTL_LCK and COMPILER_RT_HAS_ATOMICS as appropriate.
michaelwoerister
force-pushed
the
update-profiler-rt-build
branch
from
d4dfbeb to
0ffc573
Compare
|
Clang version updated. @bors r=alexcrichton |
|
📌 Commit 0ffc573 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 0ffc573 with merge 9bee31424656ffbdc627226a394857a8aeb80ff9... |
|
@bors retry |
bors
added a commit
that referenced
this pull request
May 8, 2019
…lexcrichton libprofiler_builtins: Set compilation flags more correctly for C code. In particular, set `COMPILER_RT_HAS_FCNTL_LCK` and `COMPILER_RT_HAS_ATOMICS` as appropriate. This should get rid of the various runtime warnings when executing instrumented binaries. The build script is using a heuristic here that hopefully is sufficient for the time being. r? @alexcrichton Fixes #59531.
|
☀️ Test successful - checks-travis, status-appveyor |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 8, 2019
Tested on commit rust-lang/rust@3f5152e. Direct link to PR: <rust-lang/rust#60402> 💔 rls on windows: test-pass → test-fail (cc @Xanewok, @rust-lang/infra). 🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
|
It landed I'm wondering how RLS could be affected by these changes... |
|
There's a spurious test in RLS 😓 |
|
Ah, OK. Thanks for the info, @kennytm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, set
COMPILER_RT_HAS_FCNTL_LCKandCOMPILER_RT_HAS_ATOMICSas appropriate. This should get rid of the various runtime warnings when executing instrumented binaries.The build script is using a heuristic here that hopefully is sufficient for the time being.
r? @alexcrichton
Fixes #59531.