Skip to content

Use mod #6007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use mod #6007

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/libcore/path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ pub trait GenericPath {
fn is_restricted(&self) -> bool;

fn normalize(&self) -> Self;

fn is_absolute(&self) -> bool;
}

#[cfg(windows)]
Expand Down Expand Up @@ -379,10 +381,11 @@ impl ToStr for PosixPath {
// FIXME (#3227): when default methods in traits are working, de-duplicate
// PosixPath and WindowsPath, most of their methods are common.
impl GenericPath for PosixPath {

fn from_str(s: &str) -> PosixPath {
let mut components = ~[];
for str::each_split_nonempty(s, |c| c == '/') |s| { components.push(s.to_owned()) }
for str::each_split_nonempty(s, |c| c == '/') |s| {
components.push(s.to_owned())
}
let is_absolute = (s.len() != 0 && s[0] == '/' as u8);
return PosixPath { is_absolute: is_absolute,
components: components }
Expand Down Expand Up @@ -540,6 +543,10 @@ impl GenericPath for PosixPath {
// ..self
}
}

fn is_absolute(&self) -> bool {
self.is_absolute
}
}


Expand All @@ -563,7 +570,6 @@ impl ToStr for WindowsPath {


impl GenericPath for WindowsPath {

fn from_str(s: &str) -> WindowsPath {
let host;
let device;
Expand Down Expand Up @@ -809,6 +815,10 @@ impl GenericPath for WindowsPath {
components: normalize(self.components)
}
}

fn is_absolute(&self) -> bool {
self.is_absolute
}
}


Expand Down
1 change: 0 additions & 1 deletion src/librustc/front/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ fn mk_std(cx: &TestCtxt) -> @ast::view_item {
ast::view_item_use(
~[@nospan(ast::view_path_simple(id_std,
path_node(~[id_std]),
ast::type_value_ns,
cx.sess.next_node_id()))])
} else {
ast::view_item_extern_mod(id_std, ~[@mi],
Expand Down
4 changes: 2 additions & 2 deletions src/librustc/middle/resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,7 @@ pub impl Resolver {

let mut module_path = ~[];
match view_path.node {
view_path_simple(_, full_path, _, _) => {
view_path_simple(_, full_path, _) => {
let path_len = full_path.idents.len();
assert!(path_len != 0);

Expand All @@ -1435,7 +1435,7 @@ pub impl Resolver {
// Build up the import directives.
let module_ = self.get_module_from_parent(parent);
match view_path.node {
view_path_simple(binding, full_path, _, _) => {
view_path_simple(binding, full_path, _) => {
let source_ident = *full_path.idents.last();
let subclass = @SingleImport(binding,
source_ident);
Expand Down
7 changes: 1 addition & 6 deletions src/libsyntax/ast.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1100,11 +1100,6 @@ pub struct path_list_ident_ {

pub type path_list_ident = spanned<path_list_ident_>;

#[auto_encode]
#[auto_decode]
#[deriving(Eq)]
pub enum namespace { module_ns, type_value_ns }

pub type view_path = spanned<view_path_>;

#[auto_encode]
Expand All @@ -1117,7 +1112,7 @@ pub enum view_path_ {
// or just
//
// foo::bar::baz (with 'baz =' implicitly on the left)
view_path_simple(ident, @Path, namespace, node_id),
view_path_simple(ident, @Path, node_id),

// foo::bar::*
view_path_glob(@Path, node_id),
Expand Down
5 changes: 3 additions & 2 deletions src/libsyntax/ast_util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ pub fn id_visitor(vfn: @fn(node_id)) -> visit::vt<()> {
view_item_use(ref vps) => {
for vps.each |vp| {
match vp.node {
view_path_simple(_, _, _, id) => vfn(id),
view_path_simple(_, _, id) => vfn(id),
view_path_glob(_, id) => vfn(id),
view_path_list(_, _, id) => vfn(id)
}
Expand Down Expand Up @@ -551,7 +551,8 @@ pub fn walk_pat(pat: @pat, it: &fn(@pat)) {

pub fn view_path_id(p: @view_path) -> node_id {
match p.node {
view_path_simple(_, _, _, id) | view_path_glob(_, id) |
view_path_simple(_, _, id) |
view_path_glob(_, id) |
view_path_list(_, _, id) => id
}
}
Expand Down
1 change: 0 additions & 1 deletion src/libsyntax/ext/pipes/ast_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ impl ext_ctxt_ast_builder for @ext_ctxt {
],
codemap::dummy_sp()
),
ast::type_value_ns,
self.next_id()
),
span: codemap::dummy_sp()
Expand Down
21 changes: 8 additions & 13 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ use ast::{item_mac, item_mod, item_struct, item_trait, item_ty, lit, lit_};
use ast::{lit_bool, lit_float, lit_float_unsuffixed, lit_int};
use ast::{lit_int_unsuffixed, lit_nil, lit_str, lit_uint, local, m_const};
use ast::{m_imm, m_mutbl, mac_, mac_invoc_tt, matcher, match_nonterminal};
use ast::{match_seq, match_tok, method, mode, module_ns, mt, mul, mutability};
use ast::{match_seq, match_tok, method, mode, mt, mul, mutability};
use ast::{named_field, neg, node_id, noreturn, not, pat, pat_box, pat_enum};
use ast::{pat_ident, pat_lit, pat_range, pat_region, pat_struct};
use ast::{pat_tup, pat_uniq, pat_wild, private};
Expand All @@ -54,7 +54,7 @@ use ast::{tt_nonterminal, tuple_variant_kind, Ty, ty_, ty_bot, ty_box};
use ast::{ty_field, ty_fixed_length_vec, ty_closure, ty_bare_fn};
use ast::{ty_infer, ty_method};
use ast::{ty_nil, TyParam, TyParamBound, ty_path, ty_ptr, ty_rptr};
use ast::{ty_tup, ty_u32, ty_uniq, ty_vec, type_value_ns, uniq};
use ast::{ty_tup, ty_u32, ty_uniq, ty_vec, uniq};
use ast::{unnamed_field, unsafe_blk, unsafe_fn, view_item};
use ast::{view_item_, view_item_extern_mod, view_item_use};
use ast::{view_path, view_path_glob, view_path_list, view_path_simple};
Expand Down Expand Up @@ -4224,13 +4224,6 @@ pub impl Parser {
fn parse_view_path(&self) -> @view_path {
let lo = self.span.lo;

let namespace;
if self.eat_keyword(&~"mod") {
namespace = module_ns;
} else {
namespace = type_value_ns;
}

let first_ident = self.parse_ident();
let mut path = ~[first_ident];
debug!("parsed view_path: %s", *self.id_to_str(first_ident));
Expand All @@ -4250,8 +4243,9 @@ pub impl Parser {
rp: None,
types: ~[] };
return @spanned(lo, self.span.hi,
view_path_simple(first_ident, path, namespace,
self.get_id()));
view_path_simple(first_ident,
path,
self.get_id()));
}

token::MOD_SEP => {
Expand Down Expand Up @@ -4306,8 +4300,9 @@ pub impl Parser {
idents: path,
rp: None,
types: ~[] };
return @spanned(lo, self.span.hi,
view_path_simple(last, path, namespace, self.get_id()));
return @spanned(lo,
self.span.hi,
view_path_simple(last, path, self.get_id()));
}

// matches view_paths = view_path | view_path , view_paths
Expand Down
5 changes: 1 addition & 4 deletions src/libsyntax/print/pprust.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1816,10 +1816,7 @@ pub fn print_meta_item(s: @ps, item: @ast::meta_item) {

pub fn print_view_path(s: @ps, vp: @ast::view_path) {
match vp.node {
ast::view_path_simple(ident, path, namespace, _) => {
if namespace == ast::module_ns {
word_space(s, ~"mod");
}
ast::view_path_simple(ident, path, _) => {
if path.idents[vec::len(path.idents)-1u] != ident {
print_ident(s, ident);
space(s.s);
Expand Down
24 changes: 0 additions & 24 deletions src/test/run-pass/use-mod.rs

This file was deleted.