Skip to content

Remove Cycle::try_fold override #56904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Remove Cycle::try_fold override #56904

merged 1 commit into from
Dec 17, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Dec 17, 2018

Fixes #56883

@rust-highfive
Copy link
Contributor

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2018
@sinkuu
Remove <Cycle as Iterator>::try_fold override
f0483f7 
It was a incorrect optimization.
@sinkuu sinkuu changed the title Fix Cycle::try_fold Remove Cycle::try_fold override Dec 17, 2018
@sinkuu
Copy link
Contributor Author

sinkuu commented Dec 17, 2018

After fixing the bug, it no longer improves benchmark. So, now this PR just removes the override.

@bluss
Copy link
Member

bluss commented Dec 17, 2018

@bors r+ rollup

Makes sense. Thanks!

@bors
Copy link
Collaborator

bors commented Dec 17, 2018

📌 Commit f0483f7 has been approved by bluss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2018
@nagisa
Copy link
Member

nagisa commented Dec 17, 2018

IMHO this should be p=1 and landed ASAP, @bluss, not as part of rollup, as it fixes invalid behaviour in valid code (i.e. problem as bad as soundness issues).

@bluss
Copy link
Member

bluss commented Dec 17, 2018

@bors p=1 rollup-

Yes. Let's see if bors can do that. There are several bugfixes queued, but looks like we're not overtaking something more critical.

@bors
Copy link
Collaborator

bors commented Dec 17, 2018

⌛ Testing commit f0483f7 with merge adbfec2...

bors added a commit that referenced this pull request Dec 17, 2018
@bors
Auto merge of #56904 - sinkuu:cycle_fold, r=bluss
adbfec2 
Remove Cycle::try_fold override

Fixes #56883
@bors
Copy link
Collaborator

bors commented Dec 17, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: bluss
Pushing adbfec2 to master...

@bors bors merged commit f0483f7 into rust-lang:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@withoutboats withoutboats

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sinkuu @rust-highfive @bluss @bors @nagisa @withoutboats