Stable 1.31.0 release #56455
Merged
Stable 1.31.0 release #56455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=200 |
|
📌 Commit 647fed5edbf00f9fab3b9eb6ccb66326fda2bcca has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
reviewed
Dec 3, 2018
src/bootstrap/builder.rs
Outdated
| @@ -443,7 +443,8 @@ impl<'a> Builder<'a> { | |||
| doc::RustdocBook, | |||
| doc::RustByExample, | |||
| doc::RustcBook, | |||
| doc::CargoBook | |||
| doc::CargoBook, | |||
| doc::EditionGuide | |||
There was a problem hiding this comment.
Nit: maybe we can add a trailing comma here?
|
⌛ Testing commit 647fed5edbf00f9fab3b9eb6ccb66326fda2bcca with merge 89425a9981f97378a76ef09efd27d3ba2f6f7c71... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors r- retry Lots of broken links. |
bors
added
S-waiting-on-author
Mark-Simulacrum
force-pushed
the
stable-next
branch
from
647fed5 to
5a31783
Compare
|
@bors r+ p=200 |
|
📌 Commit 5a31783 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 3, 2018
Stable 1.31.0 release This also includes a patch to the edition guide inclusion such that it should actually get built. It will need to be forward-ported to master (and beta, but that'll come as master/beta promotion). cc @rust-lang/release
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes a patch to the edition guide inclusion such that it should actually get built. It will need to be forward-ported to master (and beta, but that'll come as master/beta promotion).
cc @rust-lang/release