Skip to content

std: Don't let rust_panic get inlined #54590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2018
Merged

std: Don't let rust_panic get inlined #54590

merged 1 commit into from
Sep 29, 2018

Conversation

alexcrichton
Copy link
Member

It's meant for breakpoints, so if it gets inlined we can't set a
breakpoint on it easily!

Will hopefully help fix at least one aspect of #49013

@alexcrichton
std: Don't let rust_panic get inlined
243030b 
It's meant for breakpoints, so if it gets inlined we can't set a
breakpoint on it easily!
@alexcrichton alexcrichton mentioned this pull request Sep 26, 2018
Closed
@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2018
@dtolnay
Copy link
Member

dtolnay commented Sep 26, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 26, 2018

📌 Commit 243030b has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2018
@bors
Copy link
Collaborator

bors commented Sep 28, 2018

⌛ Testing commit 243030b with merge 02c2f0d54d78d591237e14ecde03aa51a28adfef...

@bors
Copy link
Collaborator

bors commented Sep 28, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2018
@rust-highfive
Copy link
Contributor

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:07d840fa:start=1538161892939494988,finish=1538161892944842095,duration=5347107
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:22c8d5ee
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0bb440d5
travis_time:start:0bb440d5
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06e7a45e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member Author

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2018
@kennytm kennytm mentioned this pull request Sep 29, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Sep 29, 2018
@kennytm
Rollup merge of rust-lang#54590 - alexcrichton:inline-never-rust-pani…
0ca68bb 
…c, r=dtolnay

std: Don't let `rust_panic` get inlined

It's meant for breakpoints, so if it gets inlined we can't set a
breakpoint on it easily!

Will hopefully help fix at least one aspect of rust-lang#49013
bors added a commit that referenced this pull request Sep 29, 2018
@bors
Auto merge of #54660 - kennytm:rollup, r=kennytm
9653f79 
Rollup of 8 pull requests

Successful merges:

 - #54564 (Add 1.29.1 release notes)
 - #54567 (Include path in stamp hash for debuginfo tests)
 - #54577 (rustdoc: give proc-macros their own pages)
 - #54590 (std: Don't let `rust_panic` get inlined)
 - #54598 (Remove useless lifetimes from `Pin` `impl`s.)
 - #54604 (Added help message for `self_in_typedefs` feature gate)
 - #54635 (Improve docs for std::io::Seek)
 - #54645 (Compute Android gdb version in compiletest)
@bors bors merged commit 243030b into rust-lang:master Sep 29, 2018
@bors
Copy link
Collaborator

bors commented Sep 29, 2018

⌛ Testing commit 243030b with merge 9653f79...

@kennytm
Copy link
Member

kennytm commented Oct 2, 2018

@bors retry r- Wrongly rescheduled.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 2, 2018
@alexcrichton alexcrichton deleted the inline-never-rust-panic branch October 8, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @dtolnay @bors @kennytm