Skip to content

Update lint plugin sample code. #52373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2018
Merged

Update lint plugin sample code. #52373

merged 1 commit into from
Jul 16, 2018

Conversation

eonil
Copy link

@eonil eonil commented Jul 14, 2018

The sample code is out of sync with latest test code and broken.
I just copied missing feature gates.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2018
@kennytm
Copy link
Member

kennytm commented Jul 14, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 14, 2018

📌 Commit d61540e has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 14, 2018
@bors
Copy link
Collaborator

bors commented Jul 16, 2018

⌛ Testing commit d61540e with merge 99140df...

bors added a commit that referenced this pull request Jul 16, 2018
@bors
Auto merge of #52373 - eonil:master, r=kennytm
99140df 
Update lint plugin sample code.

The sample code is out of sync with latest test code and broken.
I just copied missing feature gates.
@bors
Copy link
Collaborator

bors commented Jul 16, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 99140df to master...

@bors bors merged commit d61540e into rust-lang:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eonil @rust-highfive @kennytm @bors @frewsxcv