-
Notifications
You must be signed in to change notification settings - Fork 13.3k
refactor and cleanup region errors for NLL #52021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That said, I might like to land this PR anyway, just to give us more to build from. |
37bfd0c
to
e91c818
Compare
I haven't updated the stderr files yet, but the general output we are creating looks like this:
There are a bunch of "to do" items here:
|
Another example:
In this case, my final goal might look like this:
This could be done with:
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Let me know if you wish to merge as is or with a mild clean up and I can give it a further pass once they're in master. |
9b929d3
to
076120c
Compare
Mostly I don't want to try and get the "perfect message" in this PR. I'd be happy to do some mild cleanup, but also happy to land as is and do cleanup after landing. Also, this code will hopefully pass travis now. (Had a few things to fix.) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
076120c
to
0c15d35
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
0c15d35
to
727f017
Compare
LL | self.x.iter().map(|a| a.0) | ||
| ^^^^^^^^^^^^^ | ||
| ^^^^^^ cast requires that `'1` must outlive `'static` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm intrigued where the cast
category is coming from here...
@bors r+ |
📌 Commit 727f017 has been approved by |
refactor and cleanup region errors for NLL This is a WIP commit. It simplifies some of the code from #51536 and extends a few more steps towards the errors that @davidtwco and I were shooting for. These are intended as a replacement for the general "unable to infer lifetime" messages -- one that is actually actionable. We're certainly not there yet, but the overall shape hopefully gets a bit clearer. I'm thinking about trying to open up an internals thread to sketch out the overall plan and perhaps discuss how to get the wording right, which special cases to handle, etc. r? @estebank cc @davidtwco
☀️ Test successful - status-appveyor, status-travis |
This is a WIP commit. It simplifies some of the code from #51536 and extends a few more steps towards the errors that @davidtwco and I were shooting for. These are intended as a replacement for the general "unable to infer lifetime" messages -- one that is actually actionable. We're certainly not there yet, but the overall shape hopefully gets a bit clearer.
I'm thinking about trying to open up an internals thread to sketch out the overall plan and perhaps discuss how to get the wording right, which special cases to handle, etc.
r? @estebank
cc @davidtwco