Improve docs for slice::from_raw_parts #51423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Picking someone from libs... r? @sfackler |
pietroalbini
added
S-waiting-on-review
|
Also see #51134 where I previously changed these docs. |
sfackler
reviewed
Jun 9, 2018
src/libcore/slice/mod.rs
Outdated
| /// `p` must be non-null and aligned, even for zero-length slices, as is | ||
| /// required for all references. However, for zero-length slices, `p` can be | ||
| /// a bogus non-dereferencable pointer such as [`NonNull::dangling()`]. | ||
| /// `data` must be non-null and aligned, even for zero-length slices. The |
There was a problem hiding this comment.
Is this the reason or a reason?
There was a problem hiding this comment.
I think "A reason" is more correct. Will fix.
|
@bors r+ rollup |
|
📌 Commit 426f06f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 11, 2018
Improve docs for slice::from_raw_parts Explain why the pointer must be non-null and aligned. Cc @hsivonen
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain why the pointer must be non-null and aligned.
Cc @hsivonen