Skip to content

Update the clippy submodule and enable building edition crates #51322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 3, 2018

r? @alexcrichton

This is extremely hacky, but I see no way other than reverting the 2018 edition update for clippy

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2018
@rust-highfive

This comment has been minimized.

@oli-obk oli-obk force-pushed the clippy_submodule branch from 569a0c3 to 4e622da Compare June 3, 2018 08:27
@kennytm
Copy link
Member

kennytm commented Jun 5, 2018

Heh. Could we get cargo to recognize RUSTC_BOOTSTRAP=1 instead of sprinkling this everywhere?

@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 5, 2018

Sure. I'll open a PR against cargo

@oli-obk oli-obk closed this Jun 5, 2018
bors added a commit to rust-lang/cargo that referenced this pull request Jun 6, 2018
Allow rustc bootstrap to use unstable features even though it's using a beta-cargo

This is the sane alternative to rust-lang/rust#51322 (comment)

cc @kennytm
@oli-obk oli-obk deleted the clippy_submodule branch June 15, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants