Skip to content

Remove nll from rust_2018_preview #50609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2018
Merged

Remove nll from rust_2018_preview #50609

merged 1 commit into from
May 11, 2018

Conversation

alexcrichton
Copy link
Member

NLL isn't quite ready yet so gonna hold off on inserting it into the preview.

@alexcrichton
Remove nll from rust_2018_preview
98eab06 
NLL isn't quite ready yet so gonna hold off on inserting it into the preview.
@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2018
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 10, 2018

📌 Commit 98eab06 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2018
@aturon
Copy link
Member

aturon commented May 11, 2018

@bors: p=1

prioritizing for edition preview

@bors
Copy link
Collaborator

bors commented May 11, 2018

⌛ Testing commit 98eab06 with merge 6923fb5...

bors added a commit that referenced this pull request May 11, 2018
@bors
Auto merge of #50609 - alexcrichton:no-nll-preview, r=nikomatsakis
6923fb5 
Remove `nll` from `rust_2018_preview`

NLL isn't quite ready yet so gonna hold off on inserting it into the preview.
@bors
Copy link
Collaborator

bors commented May 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 6923fb5 to master...

@bors bors merged commit 98eab06 into rust-lang:master May 11, 2018
@pietroalbini
Copy link
Member

prioritizing for edition preview

Should this land on 1.27 or 1.28?

@alexcrichton alexcrichton deleted the no-nll-preview branch May 11, 2018 14:05
@alexcrichton
Copy link
Member Author

@pietroalbini nah the edition preview is nightly-only, so no need to backport

@nblumhardt
Copy link

Just to clarify, does this mean that NLL is in doubt for Rust 2018? We're working on something we'd like to ship against stable later this year, and we're finding it hard to imagine living without NLL :-)

@aturon
Copy link
Member

aturon commented Jun 7, 2018

@nblumhardt No, not at all! We were sprinting to get the very first preview of the Edition working, and NLL wasn't quite ready at that point. But it will definitely be in Rust 2018.

@nblumhardt
Copy link

Phew! 😅 thanks @aturon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alexcrichton @rust-highfive @nikomatsakis @bors @aturon @pietroalbini @nblumhardt @eddyb