Skip to content

Remove unneeded trait implementations titles #49335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2018
Merged

Remove unneeded trait implementations titles #49335

merged 1 commit into from
Apr 6, 2018

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2018
QuietMisdreavus
QuietMisdreavus reviewed Mar 28, 2018
View reviewed changes
src/test/rustdoc/unneeded-trait-implementations-title.rs Outdated

pub struct Bar;

// @!has foo/struct.Bar.html 'Trait implementations'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "implementations" being lowercase here going to cause a problem? I remember in the past we had a misspelled string in a @!has rule, which is always going to be false, but i don't remember whether the htmldocck.py check is case-sensitive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is case sensitive (which caused me a few issues).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the real header capitalizes the "I" there, so that should be changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh indeed!

@GuillaumeGomez GuillaumeGomez force-pushed the remove-unneeded-trait-implementations-title branch from b7b6eff to dc2ec23 Compare March 28, 2018 15:34
@GuillaumeGomez
Copy link
Member Author

Updated, let's see if it still works. :)

@GuillaumeGomez GuillaumeGomez force-pushed the remove-unneeded-trait-implementations-title branch from dc2ec23 to d91a821 Compare March 29, 2018 12:33
@GuillaumeGomez
Copy link
Member Author

Test failed because there is "Auto Trait Implementations", which matches what we were looking for.

@QuietMisdreavus
Copy link
Member

Aha! In that case, i've seen other tests have luck using @matches instead and turning the rule into \ATrait Implementations\Z (or whatever the rules for "beginning/end of string" are) instead.

@GuillaumeGomez
Copy link
Member Author

Open an issue for them. :p

@QuietMisdreavus QuietMisdreavus mentioned this pull request Apr 5, 2018
Closed
@QuietMisdreavus
Copy link
Member

Whoops, sorry for letting this slip! I've opened #49713 to explore an audit of the rustdoc tests.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 5, 2018

📌 Commit d91a821 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2018
@bors
Copy link
Collaborator

bors commented Apr 6, 2018

⌛ Testing commit d91a821 with merge 2253216...

bors added a commit that referenced this pull request Apr 6, 2018
@bors
Auto merge of #49335 - GuillaumeGomez:remove-unneeded-trait-implement…
2253216 
…ations-title, r=QuietMisdreavus

Remove unneeded trait implementations titles

r? @QuietMisdreavus
@bors
Copy link
Collaborator

bors commented Apr 6, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 2253216 to master...

@bors bors merged commit d91a821 into rust-lang:master Apr 6, 2018
@GuillaumeGomez GuillaumeGomez deleted the remove-unneeded-trait-implementations-title branch April 7, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus left review comments

Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @rust-highfive