Pass correct span when lowering grouped imports #47021
Conversation
Solves incorrect diagnostics for unused or deprecated imports. Closes rust-lang#46576. Deprecated imports had an existing test which asserted the incorrect span. That test has been corrected as part of this commit.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r=me once travis passes |
estebank
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 8d49d11 has been approved by |
estebank
added
S-waiting-on-bors
…tebank Pass correct span when lowering grouped imports Solves incorrect diagnostics for unused or deprecated imports. Closes #46576. Deprecated imports had an existing test which asserted the incorrect span. That test has been corrected as part of this commit.
|
☀️ Test successful - status-appveyor, status-travis |
Solves incorrect diagnostics for unused or deprecated imports. Closes #46576.
Deprecated imports had an existing test which asserted the incorrect span.
That test has been corrected as part of this commit.