Skip to content

Speedup search loading when search url is received #46221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

GuillaumeGomez
Copy link
Member

Fixes #45971.

r? @nrc

cc @rust-lang/docs

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2017
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an improvement since we won't see the 'main' page, but it doesn't seem like it will actually speed anything up. Questions:

  • would it actually be possible to get the search results quicker, or is this as good as it gets?
  • would it make any difference if we didn't download the 'main' page, rather than just not show it? Is that even possible to do?

So r+ for this, but curious if we can do better too.

@GuillaumeGomez
Copy link
Member Author

would it actually be possible to get the search results quicker, or is this as good as it gets?

To get results faster, we need the search to be faster. Other (opened) PRs of mine are improving this. However, there's no magic in here and unfortunately, I don't think we'll be able to be this much faster...

would it make any difference if we didn't download the 'main' page, rather than just not show it? Is that even possible to do?

What is the 'main' page you're referring to? If you're talking about the docs, we cannot not have it.

@kennytm
Copy link
Member

kennytm commented Nov 29, 2017

Triage — Hi @nrc, is @GuillaumeGomez's answers in #46221 (comment) satisfactory for r+?

@kennytm
Copy link
Member

kennytm commented Dec 6, 2017

@nrc Ping for review again (on #rust-internals as well)!

@nrc
Copy link
Member

nrc commented Dec 6, 2017

@bors: r+

@bors
Copy link
Collaborator

bors commented Dec 6, 2017

📌 Commit de3a291 has been approved by nrc

@kennytm
Copy link
Member

kennytm commented Dec 6, 2017

@bors rollup

@bors
Copy link
Collaborator

bors commented Dec 7, 2017

⌛ Testing commit de3a291 with merge bb1bd88...

bors added a commit that referenced this pull request Dec 7, 2017
Speedup search loading when search url is received

Fixes #45971.

r? @nrc

cc @rust-lang/docs
@bors
Copy link
Collaborator

bors commented Dec 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nrc
Pushing bb1bd88 to master...

@bors bors merged commit de3a291 into rust-lang:master Dec 7, 2017
@GuillaumeGomez GuillaumeGomez deleted the doc-script-load-speedup branch December 7, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants